cleanup

MetaMask · Sep 24, 2024 · f9cfe42 · f9cfe42
1 parent fde1aba
commit f9cfe42
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/packages/queued-request-controller/src/QueuedRequestController.test.ts b/packages/queued-request-controller/src/QueuedRequestController.test.ts
@@ -612,7 +612,7 @@ describe('QueuedRequestController', () => {
           }),
           networkControllerSetActiveNetwork: jest
             .fn()
-            .mockRejectedValue(switchError),
+            .mockRejectedValueOnce(switchError),
         });
         const controller = buildQueuedRequestController({
           messenger: buildQueuedRequestControllerMessenger(messenger),
@@ -655,19 +655,19 @@ describe('QueuedRequestController', () => {
         const { messenger } = buildControllerMessenger({
           networkControllerGetState: jest.fn().mockReturnValue({
             ...getDefaultNetworkControllerState(),
-            selectedNetworkClientId: 'selectedNetworkClientId',
+            selectedNetworkClientId: 'mainnet',
           }),
           networkControllerSetActiveNetwork: jest
             .fn()
-            .mockRejectedValue(switchError),
+            .mockRejectedValueOnce(switchError),
         });
         const controller = buildQueuedRequestController({
           messenger: buildQueuedRequestControllerMessenger(messenger),
           shouldRequestSwitchNetwork: ({ method }) =>
             method === 'method_requiring_network_switch',
         });
 
-        // should not switch
+        // no switch required
         const firstRequest = controller.enqueueRequest(
           {
             ...buildRequest(),
@@ -697,19 +697,19 @@ describe('QueuedRequestController', () => {
         expect(secondRequestNext).not.toHaveBeenCalled();
 
         await firstRequest;
-        await expect(secondRequest).rejects.toThrow(new Error('switch error'));
+        await expect(secondRequest).rejects.toThrow(switchError);
       });
 
       it('correctly processes the next item in the queue', async () => {
         const switchError = new Error('switch error');
         const { messenger } = buildControllerMessenger({
           networkControllerGetState: jest.fn().mockReturnValue({
             ...getDefaultNetworkControllerState(),
-            selectedNetworkClientId: 'selectedNetworkClientId',
+            selectedNetworkClientId: 'mainnet',
           }),
           networkControllerSetActiveNetwork: jest
             .fn()
-            .mockRejectedValue(switchError),
+            .mockRejectedValueOnce(switchError),
         });
         const controller = buildQueuedRequestController({
           messenger: buildQueuedRequestControllerMessenger(messenger),
@@ -1037,7 +1037,6 @@ function buildQueuedRequestControllerMessenger(
     allowedActions: [
       'NetworkController:getState',
       'NetworkController:setActiveNetwork',
-      'SelectedNetworkController:getNetworkClientIdForDomain',
     ],
     allowedEvents: ['SelectedNetworkController:stateChange'],
   });
@@ -1074,6 +1073,6 @@ function buildRequest(): QueuedRequestMiddlewareJsonRpcRequest {
     id: 'doesnt matter',
     jsonrpc: '2.0' as const,
     origin: 'example.metamask.io',
-    networkClientId: 'selectedNetworkClientId',
+    networkClientId: 'mainnet',
   };
 }