fix: (native conn.go) closeMatch logic should really close all matching conns; closes PacketConn also
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
最新的不能测延迟 |
My own fork (applied my original patch same as af60ef4) has delay test correctly working, so might be other changes causing this issue. |
|
正常情况下应该是这样的，
2.10.2全局模式点闪电图标没反应，只能用规则模式，而规则模式下只有ws节点可以用，tcp用不了，上个版本就没毛病，谢谢
…---Original---
From: "Shun ***@***.***>
Date: Fri, Aug 9, 2024 15:50 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [MetaCubeX/ClashMetaForAndroid] fix: (native conn.go)`closeMatch` logic should really close all matching conns; closes PacketConnalso (PR #248)
最新的不能测延迟
My own fork (applied my original patch same as af60ef4) has delay test correctly working, so might be other changes causing this issue.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
closeMatch, the callback function returnsfalsewhen the logic not getting into matching branch. This is not correct; as perxsync.MapOf, if the callback functionfreturns false,Rangefunction stops the iteration.fshould always returntrue.Also considering at present the massive adoption of reliable byte-stream protocol based on UDP (QUIC by browsers, for example),
PacketConns should also be closed, if possible.