Feature/csckan-290 - change region/layer model to be independent models from AEMeta - and related changes #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How to create a layer - 2024-07-10.00-42-24.mp4 |
|
We don't have on_save to create other entities from the intersection table or layer/table because - each has its UI in the admin interface and saves it when saved from the admin UI. Here is a video demo 2024-07-10.03-27-20.mp4 |
afonsobspinto
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Overall looks good to me I just left some small change requests.
As agreed internally I did not test this PR as I believe @ddelpiano will be doing that shortly.
backend/composer/services/cs_ingestion/helpers/anatomical_entities_helper.py
Outdated
Show resolved
Hide resolved
afonsobspinto
previously approved these changes
Jul 10, 2024
afonsobspinto
previously approved these changes
Jul 11, 2024
…s or anatomical entity intersections
…egions, anatomical entity intersections
…ociated_entities (simple or complex)
ddelpiano
previously approved these changes
Jul 18, 2024
ddelpiano
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link - SCKAN-290
Task description