Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sckan 284 #262

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Feature/sckan 284 #262

merged 3 commits into from
Apr 11, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Apr 10, 2024 •
edited
Loading

closes https://metacell.atlassian.net/browse/SCKAN-284

  • Corrects the tests that were failing due to the model changes
  • Adds a new test case to replicate the scenario in the bug (implicit from_entities)
  • Corrects journey calculation to properly work with implicit from_entities (the last node in the current path can lead to the current via if the anatomical entity is explicit in the from_entities or if the from_entities is implicit and the via order is the next in sequence - bold was missing from the algorithm)

Misc:

  • Replaces placeholder frontend code in the origins widget with the correct name

image

image

@zsinnema zsinnema merged commit b551772 into develop Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsinnema zsinnema Awaiting requested review from zsinnema

@ddelpiano ddelpiano Awaiting requested review from ddelpiano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afonsobspinto @zsinnema