fix(editor): fix "when switch to element assemble from ap assemble->r…

…un quickly, will error" bug

reason
meta3d-ui-control-codeedit -> getMonaco() return empty because deferLoad not finish

solution
handle the empty case

contributes/meta3d-action-addcomponent/package.json

@@ -1,6 +1,6 @@
 {
     "name": "meta3d-action-addcomponent",
-    "version": "1.3.1",
+    "version": "1.3.2",
     "publisher": "meta3d",
     "repoLink": "",
     "protocol": {

contributes/meta3d-ui-control-codeedit/package.json

@@ -1,6 +1,6 @@
 {
     "name": "meta3d-ui-control-codeedit",
-    "version": "1.3.1",
+    "version": "1.3.2",
     "displayName": "代码编辑",
     "publisher": "meta3d",
     "protocol": {

contributes/meta3d-ui-control-codeedit/src/Main.ts

@@ -114,6 +114,14 @@ export let getContribute: getContributeMeta3D<uiControlContribute<inputFunc, spe
                 if (api.nullable.isNullable(editor)) {
                     let monaco = getMonaco()
 
+                    console.log("empty monaco")
+
+                    if (api.nullable.isNullable(monaco)) {
+                        return [meta3dState, null]
+                    }
+
+                    monaco = api.nullable.getExn(monaco)
+
                     editor = monaco.editor.create(container, {
                         model: monaco.editor.createModel(code, "typescript"),
                     })

doc/jiehuo.org

@@ -356,7 +356,7 @@ start position error
 
 
 
-* TODO publish and update
+* DONE publish and update
 addcomponent
 sceneview c
 gameview c
@@ -372,7 +372,9 @@ component-script
 
 * DONE fix: clone gameObject with script component error
 
-# * TODO fix: sometimes "can't find editor" error
+* DONE fix: sometimes "can't find editor" error
+
+monaco.editor?
 
 # * TODO perf: switch to element assemble too slow
 
@@ -388,12 +390,7 @@ fix gamma pass
 * DONE default scene remove Arcball_Camera2
 
 
-* TODO fix: active arcball_forsceneview->publish error
-
-
-* TODO fix: camera group can set near, far
 
-* TODO feat: add arcball component
 
 
 
@@ -571,3 +568,18 @@ can add util functions!
 
 maintain visible
 
+
+
+
+
+
+
+* TODO small improvement
+
+** TODO fix: camera group can set near, far
+
+** TODO feat: add arcball component; can set distance, phi, theta, target,
+
+** TODO fix: active arcball_forsceneview->publish error
+
+TODO hidden Arcball Camera For Scene View in sceneTree?

packages/editor-whole/gameview-render/contributes/meta3d-pipeline-webgl1-three-gameviewrender/package.json

@@ -1,6 +1,6 @@
 {
     "name": "meta3d-pipeline-webgl1-three-gameviewrender",
-    "version": "1.3.7",
+    "version": "1.3.9",
     "publisher": "meta3d",
     "protocol": {
         "name": "meta3d-pipeline-webgl1-three-gameviewrender-protocol"

packages/editor-whole/sceneview-render/contributes/meta3d-pipeline-webgl1-three-sceneviewrender/package.json

@@ -1,6 +1,6 @@
 {
     "name": "meta3d-pipeline-webgl1-three-sceneviewrender",
-    "version": "1.3.1",
+    "version": "1.3.2",
     "publisher": "meta3d",
     "protocol": {
         "name": "meta3d-pipeline-webgl1-three-sceneviewrender-protocol"

packages/editor-whole/ui/extensions/meta3d-imgui-webgl1-renderer/package.json

@@ -1,6 +1,6 @@
 {
     "name": "meta3d-imgui-webgl1-renderer",
-    "version": "1.3.1",
+    "version": "1.3.2",
     "publisher": "meta3d",
     "displayName": "imgui-webgl1-renderer",
     "protocol": {

packages/engine-scene/contributes/meta3d-component-script/package.json

@@ -1,6 +1,6 @@
 {
   "name": "meta3d-component-script",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "publisher": "meta3d",
   "protocol": {
     "name": "meta3d-component-script-protocol"

packages/engine-whole/web-render/contributes/meta3d-pipeline-webgl1-three-webrender/package.json

@@ -1,6 +1,6 @@
 {
     "name": "meta3d-pipeline-webgl1-three-webrender",
-    "version": "1.3.6",
+    "version": "1.3.7",
     "publisher": "meta3d",
     "protocol": {
         "name": "meta3d-pipeline-webgl1-three-webrender-protocol"

platform/frontend/src/external_layer/ui/app/assemble_space/components/element_assemble/run_element_visual/components/RunElementVisual.res

@@ -50,9 +50,10 @@ module Method = {
 
       ()->Js.Promise.resolve
     }, _)
-    ->Js.Promise.catch(e => {
-      service.console.errorWithExn(. e->Error.promiseErrorToExn, None)->Obj.magic
-
+    ->Js.Promise.catch(
+      e => {
+        service.console.errorWithExn(. e->Error.promiseErrorToExn, None)->Obj.magic
+      },
       // (e->Obj.magic)["errorType"] === "script"
       //   ? {
       //       loopFrameID.current =
@@ -62,8 +63,9 @@ module Method = {
 
       //       ()->Js.Promise.resolve
       //     }
-        // : e->Js.Exn.anyToExnInternal->Js.Promise.reject
-    }, _)
+      // : e->Js.Exn.anyToExnInternal->Js.Promise.reject
+      _,
+    )
     ->ignore
   }
 
@@ -136,7 +138,7 @@ let make = (~service: AssembleSpaceType.service) => {
 
   service.react.useEffect1(. () => {
     MessageUtils.showCatchedErrorMessage(() => {
-      switch Meta3dMonacoUtils.Main.getMonaco() {
+      switch Meta3dMonacoUtils.Main.getMonaco()->Meta3dCommonlib.OptionSt.fromNullable {
       | None =>
         Meta3dMonacoUtils.Main.deferLoad()
         ->Js.Promise.catch(

platform/frontend/src/external_layer/ui/app/enter_app/components/EnterApp.res

@@ -24,7 +24,7 @@ let make = (~service: FrontendType.service) => {
 
   React.useEffect1(() => {
     MessageUtils.showCatchedErrorMessage(() => {
-      switch Meta3dMonacoUtils.Main.getMonaco() {
+      switch Meta3dMonacoUtils.Main.getMonaco()->Meta3dCommonlib.OptionSt.fromNullable {
       | None =>
         Meta3dMonacoUtils.Main.deferLoad()
         ->Js.Promise.catch(

utils/meta3d-monaco-utils/src/Main.d.ts

@@ -1,3 +1,5 @@
+import { nullable } from "meta3d-commonlib-ts/src/nullable"
+
 export type monaco = any
 
-export function getMonaco(): monaco
+export function getMonaco(): nullable<monaco>