-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New callbacks to standardise some dim names #983
Conversation
Fixes additional bug in |
Actually, hold fire, still not getting coverage for https://tmpweb.net/LXAHrJ43vmBu/z_f5ac9763053bfad5_read_py#t349. I will look tomorrow... |
Now ready for review, I think I hadn't given the coverage time to update/might have been cached in browser, now back at 100% coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A normalisation callback is a good idea.
The big think I notices was that you are converting to grid_latitude
, where I think, looking at the CF Conventions, that we should be converting to latitude
instead.
I'm also uncertain about whether we want to exclude scalar coordinates, as latitude and longitude are just as sensible on point data as they are on gridded.
Reviewed by James already and comments addressed, but not sure if I can merge until he approves. Adding @daflack as reviewer for final glance (and see if merges are possible if there is at least one reviewer who accepts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a typo looks good to me.
Co-authored-by: David Flack <[email protected]>
Have discussed this PR with JamesF in person Friday, and David has also re-reviewed so dismissing review as James on holiday for 3 weeks.
Fixes #982
Also added new fix for pressure level coordinate where surface recipes actively seek cubes where there is no pressure level data, i.e. pressure level list = [], but some AIFS cubes have the pressure coordinate called 'pressure_level' so this ensures cubes use 'pressure'.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.