Adds inflow layer properties diagnostic #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jwarner8
approved these changes
Jan 9, 2024
daflack
commented
Jan 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daflack
commented
Jan 9, 2024
daflack
commented
Jan 9, 2024
jfrost-mo
reviewed
Jan 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jfrost-mo
approved these changes
Jan 11, 2024
|
Looking good now, just needs a portability review, though I don't think there is much in here that should be a problem. |
jfrost-mo
added
enhancement
jfrost-mo
force-pushed
the
352_inflow_properties_additon
branch
from
3c60533 to
6472bbd
Compare
jfrost-mo
reviewed
Mar 25, 2024
cset-workflow/includes/deterministic_plot_inflow_properties.cylc
Outdated
Show resolved
Hide resolved
daflack
commented
Mar 25, 2024
daflack
commented
Mar 25, 2024
|
Fixed merge conflicts, and rewritten the include file to account for the current way of doing things. |
|
Its been long enough. I'm going to rebase and merge this branch. |
Co-authored-by: James Frost <[email protected]>
Co-authored-by: James Frost <[email protected]>
They were not asserting what we thought.
Also reflowed docstring (mostly by accident).
The MUCIN threshold of -1.5 data was accidently a copy of the -75 data.
Co-authored-by: James Frost <[email protected]>
jfrost-mo
force-pushed
the
352_inflow_properties_additon
branch
from
6fa1d99 to
80282cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #352
fixes #261
fixed #354