Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor changes #26

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Some minor changes #26

merged 8 commits into from
Dec 11, 2023

Conversation

grummbeer
Copy link

@grummbeer grummbeer commented Dec 10, 2023

  • using str_contains for simple text matching
  • using "null safe operator" for accessing nullable objects
  • sanitize trailing slash for PinFile path
  • add test for xml renderer getBalances
  • add a missing "declare(strict_types=1)"
  • remove unused contant
  • make use of given constant
  • using arrow function for simple return

@grummbeer grummbeer marked this pull request as ready for review December 10, 2023 16:34
@grummbeer
Copy link
Author

Are you fine with do not use getters when accessing own properties?

like this?

public function toArray(): array
{
    return [
        'bankCode' => $this->bankCode->getString(),
        'accountNumber' => $this->accountNumber,
        'accountHolderName' => $this->accountHolderName,
    ];
}

@amenk
Copy link
Member

amenk commented Dec 11, 2023

Are you fine with do not use getters when accessing own properties?

like this?

public function toArray(): array
{
    return [
        'bankCode' => $this->bankCode->getString(),
        'accountNumber' => $this->accountNumber,
        'accountHolderName' => $this->accountHolderName,
    ];
}

yes

@amenk amenk merged commit afc9696 into Mestrona:master Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants