Cleanup

[grummbeer]

• add phpstan
• add phpstan to workflow
• enable workflow checks for pull_request
• add tests with coverage
• fix skipped test Builds are failing #22 (partially)
• cleanup
  • php 8 features
  • type hinting
• no functional changes
• some tests still missing

[grummbeer]

@amenk add composer.lock?

Please do some real usage tests.

[amenk]

@amenk add composer.lock?

no sure - https://getcomposer.org/doc/02-libraries.md#lock-file does not have a final recommendation, do you see benefits in adding it?

Please do some real usage tests.

We are using it with the sister project https://github.com/Mestrona/mbank
Probably that needs to be upgraded as well, if I find the time. Then I can test it.

Did you do some tests already? What is your usecase?

[grummbeer]

composer.lock

OK, i see. No need for it.

I haven't tested all commands yet. I have not made any functional changes, just a cleanup. So everything should behave as before. Your mbank works, only this line needs to be changed to the newer money api getCurrency()->getCode().

https://github.com/Mestrona/mbank/blob/2f175ffb3ebfa0884596f874bb58478b0e213d2f/app/BankTransactionTable.php#L41

My use case is similar to mbank, just with more frontend.

[amenk]

Looks good, I guess I can merge - shall I tag a new release (4.0.0) as well or do you have further plans?

[grummbeer]

plans

• some modernizing eg.

  • "preg_match(/simple matching/) > str_contains"
  • "false !== str_pos() > str_contains"
  • "$nullableObject->get() > $nullableObject?->get()" using null-safe-operator

• bugs

  • SetAppropriateITanModeCommand don't work, unsupported Parameter "--bank" and "--user" should be uniqueId and not userId

Would do this in separate MRs, this one can be merged.

[grummbeer]

Will not send more commits to this branch :-) Ready to merge from my side.

[grummbeer]

shall I tag a new release (4.0.0)

From my end, you can do.

There are some things to do

• Adding "ListITanModesCommand", > Collection of Array (using for GUI "select iTAN Mode")
• Adding more tests
• Results should be the same type, not mixed (DomDocument, SimpleXMLElement, Array, String, …)
• … some others

My time for this is running out, must go ahead with my use case. Will commit here if anything from my own implementation seems stable or practicable.

[amenk]

Release is tagged

https://github.com/Mestrona/aqbanking-php/releases/tag/4.0.0

Feel free to open issues for the todos,

Thank you so much!