Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing testing api for storage change to limits tests #219

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

MarcelGeo
Copy link
Contributor

@MarcelGeo MarcelGeo commented Nov 4, 2024

This is first usage of testing API for changing storage limits and projects count. Test for storage and project limit hit are now using new api. There is also test_available_storage_validation2 but no validation is performed here (we need to name or remove in future).

Other ➕

  • add patch to mergin client

- use limits api in project limit hit test to allow run this test separately
@MarcelGeo MarcelGeo requested review from ValentinBuira and removed request for VitorVieiraZ November 4, 2024 12:44
@coveralls
Copy link

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11719797122

Details

  • 51 of 52 (98.08%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 78.92%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/test/test_client.py 45 46 97.83%
Totals Coverage Status
Change from base Build 10833996853: 0.2%
Covered Lines: 3231
Relevant Lines: 4094

💛 - Coveralls

Copy link
Contributor

@ValentinBuira ValentinBuira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, just one small comment, and otherwise just suggestion

mergin/test/test_client.py Show resolved Hide resolved
mergin/test/test_client.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ValentinBuira ValentinBuira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, looking good now

@MarcelGeo MarcelGeo merged commit 3cc76f8 into master Nov 7, 2024
4 checks passed
@MarcelGeo MarcelGeo deleted the first-implementation-limit-overrides branch November 7, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants