Skip to content

Commit

Permalink
* Revert back function name
Browse files Browse the repository at this point in the history
* Simplify project_versions parameter
  • Loading branch information
ValentinBuira committed Nov 29, 2024
1 parent ef7bfb9 commit f0bd794
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
7 changes: 2 additions & 5 deletions mergin/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ def project_versions_count(self, project_path):
resp_json = json.load(resp)
return resp_json["count"]

def project_versions_in_range(self, project_path, since=None, to=None):
def project_versions(self, project_path, since=1, to=None):
"""
Get records of project's versions (history) in ascending order.
If neither 'since' nor 'to' is specified it will return all versions.
Expand All @@ -773,8 +773,6 @@ def project_versions_in_range(self, project_path, since=None, to=None):

if type(since) == str:
num_since = int_version(since)
elif since == None:
num_since = 1
else:
# keep the since parameter as is
num_since = since
Expand All @@ -792,8 +790,7 @@ def project_versions_in_range(self, project_path, since=None, to=None):
num_to = self.project_versions_count(project_path)
latest_version = int_version(versions[-1]["name"])
if latest_version < num_to:
# add yield here
versions += self.project_versions_in_range(project_path, f"v{latest_version+1}", f"v{num_to}")
versions += self.project_versions(project_path, f"v{latest_version+1}", f"v{num_to}")
else:
end_page = math.ceil(num_to / per_page)
for page in range(start_page, end_page + 1):
Expand Down
2 changes: 1 addition & 1 deletion mergin/report.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def create_report(mc, directory, since, to, out_file):
mp = MerginProject(directory)
project = mp.project_full_name()
mp.log.info(f"--- Creating changesets report for {project} from {since} to {to if to else 'latest'} versions ----")
versions = mc.project_versions_in_range(project, since, to if to else None)
versions = mc.project_versions(project, since, to if to else None)
versions_map = {v["name"]: v for v in versions}
headers = ["file", "table", "author", "date", "time", "version", "operation", "length", "area", "count"]
records = []
Expand Down
8 changes: 4 additions & 4 deletions mergin/test/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -1989,23 +1989,23 @@ def test_project_versions_list(mc):
assert project_info["version"] == "v5"

# get all versions
versions = mc.project_versions_in_range(project)
versions = mc.project_versions(project)
assert len(versions) == 5
assert versions[0]["name"] == "v1"
assert versions[-1]["name"] == "v5"

# get first 3 versions
versions = mc.project_versions_in_range(project, to="v3")
versions = mc.project_versions(project, to="v3")
assert len(versions) == 3
assert versions[-1]["name"] == "v3"

# get last 2 versions
versions = mc.project_versions_in_range(project, since="v4")
versions = mc.project_versions(project, since="v4")
assert len(versions) == 2
assert versions[0]["name"] == "v4"

# get range v2-v4
versions = mc.project_versions_in_range(project, since="v2", to="v4")
versions = mc.project_versions(project, since="v2", to="v4")
assert len(versions) == 3
assert versions[0]["name"] == "v2"
assert versions[-1]["name"] == "v4"
Expand Down

0 comments on commit f0bd794

Please sign in to comment.