Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying temperature #115

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Allow specifying temperature #115

wants to merge 6 commits into from

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Aug 6, 2024

Would close #41

Additions

  • Hook up temp_k arg to calc_vol() (or use ºC and call it temp_c)
  • Warn users if temperature is extrapolating beyond range (0-120ºC) OR potentially error unless extrapolate = TRUE
  • Extend temperature specification to work with meredith method
  • Clarify in documentation how meredith method works (which SIMPOL.1 coefs are being used for additional groups)
  • Add sentence in documentation about how accuracy changes with temperature in SIMPOL.1

Bug fix:

  • You can now use named vectors for SMILES input and the names are used as the chemical names.

@Aariq Aariq marked this pull request as ready for review August 9, 2024 22:52
@Aariq

This comment was marked as resolved.

@Aariq Aariq changed the title [WIP] Allow specifying temperature Allow specifying temperature Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to specify temperature
1 participant