Update the changelog and hints

Summary: Test Plan:
MercuryTechnologies · Oct 20, 2024 · ad9a1f8 · ad9a1f8
1 parent 6035a13
commit ad9a1f8
Show file tree

Hide file tree

Showing 2 changed files with 97 additions and 0 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,5 +1,6 @@
 Changelog for HLint (* = breaking change)
 
+    #1617, hints for when x <*> y could be y, e.g. []
 *   #1594, upgrade to GHC 9.10
     #1568, add mapMaybe f (reverse x) ==> reverse (mapMaybe f x)
     #1569, avoid redundant Foldable.toList calls in Foldable operations

diff --git a/hints.md b/hints.md
@@ -7723,6 +7723,102 @@ y
 <td>Warning</td>
 </tr>
 <tr>
+<td>Redundant <*></td>
+<td>
+LHS:
+<code>
+x <*> Nothing
+</code>
+<br>
+RHS:
+<code>
+Nothing
+</code>
+<br>
+</td>
+<td>Warning</td>
+</tr>
+<tr>
+<td>Redundant <*></td>
+<td>
+LHS:
+<code>
+x <*> First Nothing
+</code>
+<br>
+RHS:
+<code>
+First Nothing
+</code>
+<br>
+</td>
+<td>Warning</td>
+</tr>
+<tr>
+<td>Redundant <*></td>
+<td>
+LHS:
+<code>
+x <*> Last Nothing
+</code>
+<br>
+RHS:
+<code>
+Last Nothing
+</code>
+<br>
+</td>
+<td>Warning</td>
+</tr>
+<tr>
+<td>Redundant <*></td>
+<td>
+LHS:
+<code>
+x <*> Left a
+</code>
+<br>
+RHS:
+<code>
+Left a
+</code>
+<br>
+</td>
+<td>Warning</td>
+</tr>
+<tr>
+<td>Redundant <*></td>
+<td>
+LHS:
+<code>
+x <*> Ap []
+</code>
+<br>
+RHS:
+<code>
+Ap []
+</code>
+<br>
+</td>
+<td>Warning</td>
+</tr>
+<tr>
+<td>Redundant <*></td>
+<td>
+LHS:
+<code>
+x <*> []
+</code>
+<br>
+RHS:
+<code>
+[]
+</code>
+<br>
+</td>
+<td>Warning</td>
+</tr>
+<tr>
 <td>Monad law, left identity</td>
 <td>
 LHS: