feat(tap): Adding support for schema #66
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to read JSONL files with complex structs, including many data types like array, object, datetime, string, etc...
The current implementation offers
jsonl_type_coercion_strategy
to decide how the tap is going to infer the schema. The problem is that none of the coercion strategies works for our use case. Besides that, thejsonl_sampling_strategy
only supportsfirst
which does not work for our use case.This PR implements a possible solution, by adding a new parameter named schema. This parameter would be parsed by Meltano SDK, see here.
If the user decides to specify a fixed schema, the tap does not need to create the schema dynamically, ignoring the coercion strategy.
Changes