Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Accept new versions of python #109

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: Accept new versions of python #109

wants to merge 2 commits into from

Conversation

visch
Copy link
Member

@visch visch commented Aug 23, 2024

No description provided.

@visch visch changed the title python upgrade chore: Accept new versions of python Aug 23, 2024
@visch visch marked this pull request as draft August 23, 2024 19:05
@visch
Copy link
Member Author

visch commented Aug 23, 2024

Failing on 3.12 - 3.14. Not going to dive more, someone can feel free to it's probably not a huge fix!

@boorad
Copy link

boorad commented Aug 27, 2024

Add the following to pyproject.toml

[tool.poetry.dependencies]
# ...
numpy = [
    {version = "~=1.24.4", python = "<3.12"},
    {version = "~=1.26.4", python = ">=3.12"}
]

The fix is in numpy 2.0, and was back ported to 1.26.3 here.

I'm still not clear on what is using numpy... maybe some test lib?

@visch
Copy link
Member Author

visch commented Aug 30, 2024

Add the following to pyproject.toml

[tool.poetry.dependencies]
# ...
numpy = [
    {version = "~=1.24.4", python = "<3.12"},
    {version = "~=1.26.4", python = ">=3.12"}
]

The fix is in numpy 2.0, and was back ported to 1.26.3 here.

I'm still not clear on what is using numpy... maybe some test lib?

It's the singer-sdk it looks like so we'd probably need to do something upstream https://github.com/meltano/sdk/tree/main/singer_sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants