add filters to report_definition #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
pnadolny13
reviewed
Aug 11, 2022
| @@ -122,6 +122,15 @@ def _generate_report_definition(report_def_raw): | |||
| {"expression": metric.replace("ga_", "ga:")} | |||
| ) | |||
|
|
|||
| for filter in report_def_raw["filters"]: | |||
There was a problem hiding this comment.
@rickiesmooth thanks for the PR!
It looks like this is making filters a required entry in the report definition file. If someone upgrades to this version they'd need to update their definitions before it will run without error.
What do you think about making filters optional so its backwards compatible for users that already have the tap running and have no filters defined? It should be a simple change to use .get("filters", []) or a similar safety check.
|
@rickiesmooth do you still want to try and get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47