fix: data types and remove odax field (#131)

* Remove has_advertiser_opted_in_odax from adaccounts stream (#1) * Remove has_advertiser_opted_in_odax from adaccounts stream * Remove from schema * Fix data types for fields that can be strings (#2) * Fix data types for fields that can be strings * spend_cap to string * thumbnail_id to string * video_id --------- Co-authored-by: dsaxton-1password <[email protected]>
MeltanoLabs · Jan 8, 2024 · b737b38 · b737b38
1 parent d8fc62e
commit b737b38
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/tap_facebook/streams.py b/tap_facebook/streams.py
@@ -893,7 +893,7 @@ class CampaignStream(FacebookStream):
         Property("special_ad_category", StringType),
         Property("status", StringType),
         Property("topline_id", StringType),
-        Property("spend_cap", IntegerType),
+        Property("spend_cap", StringType),
         Property("budget_remaining", StringType),
         Property("daily_budget", IntegerType),
         Property("start_time", StringType),
@@ -947,7 +947,7 @@ class CampaignStream(FacebookStream):
         Property("promoted_object_application_type", StringType),
         Property("ad_strategy_group_id", IntegerType),
         Property("ad_strategy_id", IntegerType),
-        Property("lifetime_budget", IntegerType),
+        Property("lifetime_budget", StringType),
         Property("last_budget_toggling_time", StringType),
         Property("daily_budget", IntegerType),
         Property("special_ad_category_country", ArrayType),
@@ -1102,15 +1102,15 @@ class CreativeStream(FacebookStream):
         Property("place_page_set_id", IntegerType),
         Property("platform_customizations", StringType),
         Property("playable_asset_id", IntegerType),
-        Property("source_instagram_media_id", IntegerType),
+        Property("source_instagram_media_id", StringType),
         Property("status", StringType),
         Property("template_url", StringType),
-        Property("thumbnail_id", IntegerType),
+        Property("thumbnail_id", StringType),
         Property("thumbnail_url", StringType),
         Property("title", StringType),
         Property("url_tags", StringType),
         Property("use_page_actor_override", BooleanType),
-        Property("video_id", IntegerType),
+        Property("video_id", StringType),
         Property("template_app_link_spec_android", ArrayType(StringType)),
         Property("template_app_link_spec_ios", ArrayType(StringType)),
         Property("template_app_link_spec_ipad", ArrayType(StringType)),
@@ -1270,7 +1270,6 @@ def url_base(self) -> str:
         "disable_reason",
         "end_advertiser",
         "end_advertiser_name",
-        "has_advertiser_opted_in_odax",
         "has_migrated_permissions",
         "id",
         "is_attribution_spec_system_default",
@@ -1362,7 +1361,6 @@ def url_base(self) -> str:
         Property("disable_reason", IntegerType),
         Property("end_advertiser", StringType),
         Property("end_advertiser_name", StringType),
-        Property("has_advertiser_opted_in_odax", BooleanType),
         Property("has_migrated_permissions", BooleanType),
         Property("id", StringType),
         Property("is_attribution_spec_system_default", BooleanType),