Skip to content

Commit

Permalink
Address lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon committed Jan 31, 2024
1 parent 5073c0b commit 3ab422a
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 6 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Note: This tap currently does not support incremental state.

A full list of supported settings and capabilities is available by running: `tap-csv --about`

The `config.json` contains an array called `files` that consists of dictionary objects detailing each destination table to be passed to Singer. Each of those entries contains:
The `config.json` contains an array called `files` that consists of dictionary objects detailing each destination table to be passed to Singer. Each of those entries contains:
* `entity`: The entity name to be passed to singer (i.e. the table)
* `path`: Local path to the file to be ingested. Note that this may be a directory, in which case all files in that directory and any of its subdirectories will be recursively processed
* `keys`: The names of the columns that constitute the unique keys for that entity
Expand All @@ -41,7 +41,7 @@ Example:

```json
{
"files": [
"files": [
{ "entity" : "leads",
"path" : "/path/to/leads.csv",
"keys" : ["Id"],
Expand Down Expand Up @@ -69,7 +69,7 @@ Optionally, the files definition can be provided by an external json file:

**files_def.json**
```json
[
[
{ "entity" : "leads",
"path" : "/path/to/leads.csv",
"keys" : ["Id"]
Expand Down Expand Up @@ -155,5 +155,5 @@ meltano elt tap-csv target-jsonl

### SDK Dev Guide

See the [dev guide](https://sdk.meltano.com/en/latest/dev_guide.html) for more instructions on how to use the SDK to
See the [dev guide](https://sdk.meltano.com/en/latest/dev_guide.html) for more instructions on how to use the SDK to
develop your own taps and targets.
28 changes: 27 additions & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ singer-sdk = "~=0.34.0"
coverage = ">=7.2"
mypy = ">=1.4"
pytest = ">=7.4.4"
ruff = ">=0.1.15"
types-requests = ">=2.31.0"

[build-system]
Expand Down
2 changes: 1 addition & 1 deletion tap_csv/tests/data/alphabet_encoding.csv
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
col1,col2,col3
Á,b,c
d,e,f
g,h,i
g,h,i

0 comments on commit 3ab422a

Please sign in to comment.