Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add upgrade support #54

Conversation

matsonj
Copy link
Contributor

@matsonj matsonj commented Aug 11, 2023

adding upgrade support in python ext + fixing evidence run dev to work locally + inside codespaces

@matsonj matsonj linked an issue Aug 11, 2023 that may be closed by this pull request
@matsonj matsonj changed the title adding upgrade support feat: adding upgrade support Aug 11, 2023
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matsonj! A few nits, mostly to make Ruff happy.

evidence_ext/extension.py Outdated Show resolved Hide resolved
evidence_ext/extension.py Outdated Show resolved Hide resolved
matsonj and others added 2 commits August 11, 2023 17:31
fix args for upgrade

Co-authored-by: Edgar R. M. <[email protected]>
make ruff happy :D

Co-authored-by: Edgar R. M. <[email protected]>
@matsonj
Copy link
Contributor Author

matsonj commented Aug 12, 2023

@edgarrmondragon Thank you for the help with the CI changes - I haven't used ruff before 😅

Copy link
Contributor Author

@matsonj matsonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now?

@edgarrmondragon edgarrmondragon changed the title feat: adding upgrade support feat: Add upgrade support Aug 12, 2023
@matsonj matsonj dismissed edgarrmondragon’s stale review August 12, 2023 01:34

I think I made the required changes?

Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @matsonj!

@edgarrmondragon edgarrmondragon merged commit 786f83f into main Aug 12, 2023
1 check passed
@edgarrmondragon edgarrmondragon deleted the 12-feat-add-commands-for-updating-an-existing-evidence-project branch August 12, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: add commands for updating an existing Evidence project
2 participants