-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add upgrade support #54
feat: Add upgrade support #54
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @matsonj! A few nits, mostly to make Ruff happy.
fix args for upgrade Co-authored-by: Edgar R. M. <[email protected]>
make ruff happy :D Co-authored-by: Edgar R. M. <[email protected]>
@edgarrmondragon Thank you for the help with the CI changes - I haven't used ruff before 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now?
I think I made the required changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @matsonj!
adding upgrade support in python ext + fixing evidence run dev to work locally + inside codespaces