Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix firmware mismatch feature #42

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix firmware mismatch feature #42

merged 1 commit into from
Nov 7, 2024

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Nov 5, 2024

  • fix match for inbox driver
  • fix deployed OFED version getter
  • add more logs for troubleshooting

@coveralls
Copy link

coveralls commented Nov 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11692211121

Details

  • 11 of 87 (12.64%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.0%) to 59.088%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/host/host.go 0 1 0.0%
internal/controller/devicediscovery_controller.go 9 11 81.82%
pkg/host/mocks/HostUtils.go 0 2 0.0%
pkg/host/utils.go 0 8 0.0%
pkg/host/mocks/MaintenanceManager.go 0 63 0.0%
Files with Coverage Reduction New Missed Lines %
internal/controller/devicediscovery_controller.go 1 70.25%
pkg/host/mocks/HostManager.go 1 74.0%
internal/controller/nicdevice_controller.go 3 78.78%
Totals Coverage Status
Change from base Build 11689185532: -1.0%
Covered Lines: 1749
Relevant Lines: 2960
💛 - Coveralls

@e0ne
Fix firmware mismatch feature
89448b4 
* fix match for inbox driver
* fix deployed OFED version getter
* add more logs for troubleshooting

Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
@almaslennikov almaslennikov merged commit cef3714 into Mellanox:main Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rollandf rollandf rollandf approved these changes

@almaslennikov almaslennikov almaslennikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e0ne @coveralls @almaslennikov @rollandf