Merge pull request #51 from almaslennikov/pending-reboot-fix

fix: Set device status to PendingReboot if needed after spec validation
Mellanox · Nov 13, 2024 · b676b51 · b676b51
2 parents 176a715 + 89469db
commit b676b51
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/internal/controller/nicdevice_controller.go b/internal/controller/nicdevice_controller.go
@@ -496,6 +496,13 @@ func (r *NicDeviceReconciler) handleSpecValidation(ctx context.Context, statuses
 					status.nvConfigUpdateRequired = false
 					status.rebootRequired = false
 					status.lastStageError = errors.New(consts.FwConfigNotAppliedAfterRebootErrorMsg)
+				default:
+					// If reboot hasn't happened yet, proceed as normal and set PendingReboot status
+					log.Log.V(2).Info("reboot pending for device", "device", status.device.Name)
+					err = r.updateDeviceStatusCondition(ctx, status.device, consts.PendingRebootReason, metav1.ConditionTrue, "")
+					if err != nil {
+						status.lastStageError = err
+					}
 				}
 			}
 		}(i)