chore: implement new assert function for NAD unit tests #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10060390909Details
💛 - Coveralls |
tobiasgiese
force-pushed
the
state-test-nadconfig
branch
10 times, most recently
from
c9ec658 to
3e7c24c
Compare
| @@ -169,6 +193,25 @@ func assertCNIBinDirForDS(u *unstructured.Unstructured) { | |||
| } | |||
| } | |||
|
|
|||
| func assertNetworkAttachmentDefinition(c client.Client, expectedNadConfig *nadConfig, | |||
There was a problem hiding this comment.
Q: Should we use here GinkgoHelper() or ExpectWithOffset?
There was a problem hiding this comment.
This would be helpful for sure. We are never using GinkgoHelper or ExpectWithOffset in our tests.
Should we create a separate PR to align our tests?
There was a problem hiding this comment.
yes, I think we can update all helper functions in a separate PR
tobiasgiese
changed the title
rollandf
previously approved these changes
Jul 23, 2024
…testing Use this new function for the hostdevice network unit tests. Signed-off-by: Tobias Giese <[email protected]>
Signed-off-by: Tobias Giese <[email protected]>
Signed-off-by: Tobias Giese <[email protected]>
tobiasgiese
force-pushed
the
state-test-nadconfig
branch
from
3e7c24c to
8a07cad
Compare
|
Had to update the first commit, change is between |
|
/retest-all |
|
/retest-copy-right |
|
/retest-blackduck_scan |
|
/retest-image_scan |
rollandf
approved these changes
Jul 24, 2024
ykulazhenkov
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos: