chore: Add unit tests for nv-ipam-cni objects rendering and sync #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10093836643Details
💛 - Coveralls |
souleb
force-pushed
the
state-nv-ipam-cni-unit-test
branch
2 times, most recently
from
5279fbb to
40c19aa
Compare
souleb
changed the title
tobiasgiese
reviewed
Jul 17, 2024
tobiasgiese
reviewed
Jul 17, 2024
| }) | ||
|
|
||
| Context("Verify objects rendering", func() { | ||
| It("should create Daemonset - minimal spec", func() { |
There was a problem hiding this comment.
I know we don't have this in our other tests (AFAIK), but should we start adding negative tests?
There was a problem hiding this comment.
NB: this is just a reminder, nothing related to this PR :)
souleb
force-pushed
the
state-nv-ipam-cni-unit-test
branch
2 times, most recently
from
100e188 to
451b4a2
Compare
souleb
force-pushed
the
state-nv-ipam-cni-unit-test
branch
2 times, most recently
from
f651916 to
ed10820
Compare
e0ne
requested changes
Jul 22, 2024
souleb
force-pushed
the
state-nv-ipam-cni-unit-test
branch
2 times, most recently
from
08d5f65 to
0db488a
Compare
souleb
force-pushed
the
state-nv-ipam-cni-unit-test
branch
4 times, most recently
from
73ed0db to
bfac8b6
Compare
Signed-off-by: Soule BA <[email protected]>
souleb
force-pushed
the
state-nv-ipam-cni-unit-test
branch
from
bfac8b6 to
4dddd3c
Compare
e0ne
approved these changes
Jul 26, 2024
rollandf
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.