chore: generate docs versions var #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollandf
added
the
on hold
rollandf
commented
Jul 15, 2024
rollandf
commented
Jul 15, 2024
Pull Request Test Coverage Report for Build 10090377988Details
💛 - Coveralls |
rollandf
force-pushed
the
hack-docs-version
branch
2 times, most recently
from
b2dcccd to
4e621f8
Compare
e0ne
reviewed
Jul 22, 2024
| @@ -136,6 +138,10 @@ func main() { | |||
| if *retrieveSha { | |||
| resolveImagesSha(&release) | |||
| } | |||
| parts := strings.Split(release.NetworkOperator.Version, ".") | |||
| release.OcpDefaulChannel = fmt.Sprintf("%s.%s", parts[0], parts[1]) | |||
There was a problem hiding this comment.
Do we want to generate OCP channels list (e.g. stable,v24.4.1) too?
There was a problem hiding this comment.
We use this one for OpenShift installation via CLI where we need a single channel, not a list:
There was a problem hiding this comment.
cant we always specify default here ? then install specific operator version ?
| .PHONY: generate-docs-versions-var | ||
| generate-docs-versions-var: | ||
| cd hack && $(GO) run release.go --templateDir ./templates/docs-versions-var/ --outputDir . | ||
| mv hack/vars.yaml hack/vars.rst |
There was a problem hiding this comment.
do we want to add hack/vars.rst to .gitignore?
rollandf
force-pushed
the
hack-docs-version
branch
from
4e621f8 to
be5e1c4
Compare
rollandf
removed
the
on hold
|
/retest-image_scan |
.gitignore
Outdated
| @@ -30,3 +30,5 @@ testbin | |||
| test | |||
| build | |||
| hack/manifests | |||
|
|
|||
| hack/vars.rst | |||
hack/release.yaml
Outdated
| @@ -77,3 +78,5 @@ rdmaCni: | |||
| image: rdma-cni | |||
| repository: ghcr.io/k8snetworkplumbingwg | |||
| version: v1.2.0 | |||
| Nfd: | |||
| version: v0.13.2 | |||
There was a problem hiding this comment.
nit: its v0.15.6 now
Generate documentation var files to be used in network-operator-docs repo. Signed-off-by: Fred Rolland <[email protected]>
rollandf
force-pushed
the
hack-docs-version
branch
from
be5e1c4 to
2bc1d82
Compare
|
at some point, i think we would need to carve out docs related scripts/logic and put them in doc repo if we see we get too much of those, relying on release.yaml file from this repo. |
adrianchiris
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate documentation var files to be used
in network-operator-docs repo.