chore: add full NCP CR example #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10053779049Details
💛 - Coveralls |
|
LGTM |
noama-nv
reviewed
Jul 16, 2024
| @@ -57,3 +57,40 @@ spec: | |||
| } | |||
| ] | |||
| } | |||
| sriovDevicePlugin: | |||
There was a problem hiding this comment.
@rollandf secondaryNetwork ipoib is also applicable on openshift
ykulazhenkov
previously approved these changes
Jul 22, 2024
hack/templates/samples/mellanox.com_v1alpha1_nicclusterpolicy.template
Outdated
Show resolved
Hide resolved
rollandf
force-pushed
the
full-ncp-cr
branch
2 times, most recently
from
fb62abf to
c4e811e
Compare
tobiasgiese
reviewed
Jul 22, 2024
Comment on lines
+14
to
+18
| # | ||
| # ##### Note ##### | ||
| # This example contains all the components supported as a reference. | ||
| # User should edit the example and keep only the required components. | ||
| # |
There was a problem hiding this comment.
Suggested change
| # | |
| # ##### Note ##### | |
| # This example contains all the components supported as a reference. | |
| # User should edit the example and keep only the required components. | |
| # |
nit: do we need this example text or should we rather remove it?
There was a problem hiding this comment.
This example is a reference, that was asked from QA team to easily get the components versions, taking into account that in the future these versions will not be available in the Helm values.
This configuration probably is not a real life scenario.
|
/retest-blackduck_scan |
noama-nv
approved these changes
Jul 22, 2024
|
/retest-blackduck_scan |
2 similar comments
|
/retest-blackduck_scan |
|
/retest-blackduck_scan |
e0ne
requested changes
Jul 22, 2024
| @@ -0,0 +1,118 @@ | |||
| # Copyright 2020 NVIDIA | |||
There was a problem hiding this comment.
Please, update copyright header as at [1] and fix the year
[1]
Signed-off-by: Fred Rolland <[email protected]>
|
/retest-image_scan |
e0ne
approved these changes
Jul 25, 2024
adrianchiris
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.