Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update SR-IOV Network Operator Helm chart #662

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Nov 7, 2023

Update SR-IOV Network Operator Helm chart

@adrianchiris
Copy link
Collaborator

/lgtm

just making sure @e0ne these were copied as-is from sriov-network-operator npwg proj ?

@e0ne
Copy link
Collaborator Author

e0ne commented Nov 7, 2023

/lgtm

just making sure @e0ne these were copied as-is from sriov-network-operator npwg proj ?

yes, these CRDs are copied without any modifications

@adrianchiris
Copy link
Collaborator

is the helm chart updated in its entierty from upstream ? and not parts of it ?

@e0ne e0ne force-pushed the sriov-chart-update branch from 590d229 to 4affc1c Compare November 7, 2023 12:16
@e0ne
Copy link
Collaborator Author

e0ne commented Nov 7, 2023

is the helm chart updated in its entierty from upstream ? and not parts of it ?

the whole chart is updated now

@rollandf
Copy link
Member

rollandf commented Nov 7, 2023

Is it needed for v23.10 ?

@e0ne
Copy link
Collaborator Author

e0ne commented Nov 7, 2023

Is it needed for v23.10 ?

yes, I'll cherry-pick this commit

@e0ne
Copy link
Collaborator Author

e0ne commented Nov 7, 2023

/retest-nic_operator_helm

1 similar comment
@e0ne
Copy link
Collaborator Author

e0ne commented Nov 7, 2023

/retest-nic_operator_helm

@e0ne e0ne merged commit 9d13f43 into Mellanox:master Nov 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants