-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove PSP support #609
Conversation
retest-all |
/retest-all |
1 similar comment
/retest-all |
/retest-nic_operator_helm |
/retest-nic_operator_kind /retest-copy-right /retest-blackduck_scan /retest-image_scan |
a0cdb5c
to
1d7150d
Compare
/retest-nic_operator_helm |
@@ -608,15 +584,4 @@ spec: | |||
provider: | |||
name: NVIDIA | |||
url: https://github.com/Mellanox/network-operator/ | |||
relatedImages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related images shouldn't be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are actually automatically deleted by DEFAULT_CHANNEL=v23.7.0 CHANNELS=v23.7.0 VERSION=23.7.0 make bundle
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that the operator-sdk is now ignoring the relatedImages from the config/manifests/bases
It used to work in previous version...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it stopped working in operator-sdk v1.19.1
@almaslennikov can you rebase this one? |
1d7150d
to
67e6481
Compare
Pod Security Policy was deprecated for a long time, and in k8s 1.25 it was completely dropped. To align with the newest versions, dropping the PSP from our code Signed-off-by: amaslennikov <[email protected]>
67e6481
to
1755e2d
Compare
Done |
Thanks! Can we remove the "hold" label? |
Merging per 2 LGTMs once CI pass |
/retest-nic_operator_helm |
1 similar comment
/retest-nic_operator_helm |
Pod Security Policy was deprecated for a long time, and in k8s 1.25 it was completely dropped.
To align with the newest versions, dropping the PSP from our code