Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove PSP support #609

Merged
merged 1 commit into from
Dec 5, 2023
Merged

chore: Remove PSP support #609

merged 1 commit into from
Dec 5, 2023

Conversation

almaslennikov
Copy link
Collaborator

Pod Security Policy was deprecated for a long time, and in k8s 1.25 it was completely dropped.
To align with the newest versions, dropping the PSP from our code

@abdallahyas
Copy link
Contributor

retest-all

@abdallahyas
Copy link
Contributor

/retest-all

1 similar comment
@abdallahyas
Copy link
Contributor

/retest-all

@abdallahyas
Copy link
Contributor

/retest-nic_operator_helm

@abdallahyas
Copy link
Contributor

/retest-nic_operator_kind /retest-copy-right /retest-blackduck_scan /retest-image_scan

@abdallahyas
Copy link
Contributor

/retest-nic_operator_helm

@almaslennikov almaslennikov marked this pull request as ready for review September 28, 2023 06:28
@@ -608,15 +584,4 @@ spec:
provider:
name: NVIDIA
url: https://github.com/Mellanox/network-operator/
relatedImages:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related images shouldn't be deleted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are actually automatically deleted by DEFAULT_CHANNEL=v23.7.0 CHANNELS=v23.7.0 VERSION=23.7.0 make bundle command

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the operator-sdk is now ignoring the relatedImages from the config/manifests/bases
It used to work in previous version...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it stopped working in operator-sdk v1.19.1

@e0ne e0ne added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Sep 28, 2023
adrianchiris
adrianchiris previously approved these changes Oct 3, 2023
@adrianchiris adrianchiris dismissed their stale review October 3, 2023 08:16

was a test

@rollandf
Copy link
Member

@almaslennikov can you rebase this one?

Pod Security Policy was deprecated for a long time,
and in k8s 1.25 it was completely dropped.
To align with the newest versions, dropping the PSP from our code

Signed-off-by: amaslennikov <[email protected]>
@almaslennikov
Copy link
Collaborator Author

@almaslennikov can you rebase this one?

Done

@almaslennikov almaslennikov changed the title Remove PSP support chore: Remove PSP support Nov 30, 2023
@rollandf
Copy link
Member

@almaslennikov can you rebase this one?

Done

Thanks! Can we remove the "hold" label?

@adrianchiris adrianchiris removed the on hold This enhancement is currently on hold pending additional clarification and evaluation label Nov 30, 2023
@adrianchiris
Copy link
Collaborator

adrianchiris commented Nov 30, 2023

Merging per 2 LGTMs once CI pass

@rollandf
Copy link
Member

rollandf commented Dec 4, 2023

/retest-nic_operator_helm

1 similar comment
@rollandf
Copy link
Member

rollandf commented Dec 4, 2023

/retest-nic_operator_helm

@e0ne e0ne merged commit 30275fb into Mellanox:master Dec 5, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants