Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: remove empty config in multus examples #1225

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

rollandf
Copy link
Member

Empty config in multus, empty multus config is created causing nodes to be in not ready state.

Empty config in multus, empty multus config is created causing
nodes to be in not ready state.

Signed-off-by: Fred Rolland <[email protected]>
@rollandf rollandf requested review from e0ne and heyvister1 December 30, 2024 08:02
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12543694687

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 60.468%

Files with Coverage Reduction New Missed Lines %
controllers/ipoibnetwork_controller.go 2 83.33%
pkg/state/state_ipoib_network.go 4 75.24%
Totals Coverage Status
Change from base Build 12463574399: 0.2%
Covered Lines: 3333
Relevant Lines: 5512

💛 - Coveralls

@adrianchiris adrianchiris merged commit db3a519 into Mellanox:master Dec 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants