Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add push to OCP bundle in CI #1221

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore: Add push to OCP bundle in CI #1221

merged 1 commit into from
Jan 6, 2025
+46 −19

Conversation

dahalperin
Copy link
Contributor

  • push ocp-bundle on every merge
  • tag format is short sha commit

@dahalperin
chore: Add push to OCP bundle in CI
bbb9dc5 
- push ocp-bundle on every merge
- tag format is short sha commit

Signed-off-by: Dana Halperin <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12482315296

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.5%) to 59.797%
Files with Coverage Reduction New Missed Lines %
controllers/ipoibnetwork_controller.go 2 83.33%
pkg/state/state_ipoib_network.go 4 75.24%
api/v1alpha1/zz_generated.deepcopy.go 4 40.38%
controllers/hostdevicenetwork_controller.go 21 68.18%
Totals Coverage Status
Change from base Build 12463574399: -0.5%
Covered Lines: 3296
Relevant Lines: 5512
💛 - Coveralls

@rollandf rollandf requested a review from e0ne December 24, 2024 13:38
e0ne
e0ne requested changes Dec 30, 2024
View reviewed changes
.github/workflows/ci.yaml Show resolved Hide resolved
@e0ne e0ne merged commit dfca357 into Mellanox:master Jan 6, 2025
16 checks passed
maze88
maze88 reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@maze88 maze88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the adjustments we discussed a couple weeks ago?

.github/workflows/ci.yaml
Comment on lines +155 to +157
export DEFAULT_CHANNEL=v1.1 # hard coded
export CHANNELS=stable,v1.1 # hard coded
export VERSION=1.1.0-${{ env.VERSION_WITH_PREFIX }} # using the commit hash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these versions?
Why should they be hard coded?
@rollandf ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the versions of the bundle/application
Since that here we are building on every commit, there is no real version. That's why they are hard coded.

.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@rollandf
Copy link
Member

rollandf commented Jan 7, 2025

What about the adjustments we discussed a couple weeks ago?

@maze88 Did you comment on the PR and request changes there?

@maze88
Copy link
Collaborator

maze88 commented Jan 7, 2025 •
edited
Loading

What about the adjustments we discussed a couple weeks ago?

@maze88 Did you comment on the PR and request changes there?

No, Dana and I did a couple of sessions over MSteams.

@rollandf
Copy link
Member

rollandf commented Jan 7, 2025

What about the adjustments we discussed a couple weeks ago?

@maze88 Did you comment on the PR and request changes there?

No, Dana and I did a couple of sessions over MSteams.

I suggest to leave comments using GitHub so that everybody will be aware of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maze88 maze88 maze88 left review comments

@rollandf rollandf rollandf approved these changes

@e0ne e0ne e0ne approved these changes

@heyvister1 heyvister1 Awaiting requested review from heyvister1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dahalperin @coveralls @rollandf @maze88 @e0ne