feat: Network Operator release trigger #1203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12167662267Details
💛 - Coveralls |
rollandf
reviewed
Dec 3, 2024
| - uses: actions/checkout@v4 | ||
| with: | ||
| token: ${{ secrets.GH_TOKEN_NVIDIA_CI_CD }} | ||
| repository: ${{ github.repository_owner }}/sriov-network-operator |
There was a problem hiding this comment.
The tag will always on master branch here, no?
There was a problem hiding this comment.
no, we don't use master for sriov fork
There was a problem hiding this comment.
I mean when you do the tag, which branch you should be in?
'actions/checkout@v4' needs to get the target branch, no?
We need to start SR-IOV Network Operator release if Network Operator Release pipeline started. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
rollandf
approved these changes
Dec 30, 2024
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jan 7, 2025
This is a manual PR until Mellanox#1203 is merged. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
heyvister1
reviewed
Jan 7, 2025
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| token: ${{ secrets.GH_TOKEN_NVIDIA_CI_CD }} |
There was a problem hiding this comment.
Were you able to check that secret was propagated to sriov-network-operator? We had some issues with that on docs CI job
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jan 7, 2025
This is a manual PR until Mellanox#1203 is merged. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to start SR-IOV Network Operator release if Network Operator Release pipeline started.