chore: downgrade go version for apply-crds package #1132
Conversation
There is a project that wants to consume this package. As this project sticks to the Go version that is also used by the lates stable Kubernetes version we should also downgrade this version to be compatible. Signed-off-by: Tobias Giese <[email protected]>
what project is it? I don't like an idea of downgrading golang and having different version for several components |
Pull Request Test Coverage Report for Build 11682795344Details
💛 - Coveralls |
It is an internal project. In this project we are pinning the version to the latest stable Kubernetes version -- which is currently go1.22 for Kubernetes v1.31. As the latest go1.22 patch version (with also fixed CVEs) is go1.22.8 I want to set the go version for this package. I understand your concerns, but it breaks the usage of this package for projects that stick to Kubernetes' Golang version. |
There was a problem hiding this comment.
I don't like the idea of using different go version within the same code tree, but I don't see any good alternative for this case.
We are downgrading go version for isolated app (it doesn't import anything from the pkg), so this change is acceptable from my point of view.
I think CVEs are not an issue here, because we are still using the lates go image to build the binary.
|
We will move the code to NVIDIA/k8s-operator-libs#50 anway, so we can close this PR. |
There is a project that wants to consume this package.
As this project sticks to the Go version that is also used by the lates stable Kubernetes version we should also downgrade this version to be compatible.