feat: Remove kubectl binary from container and apply CRDs with client-go #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
from
c133cf4 to
2837707
Compare
tobiasgiese
changed the title
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
from
2837707 to
7245b83
Compare
Pull Request Test Coverage Report for Build 11613498909Details
💛 - Coveralls |
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
11 times, most recently
from
8175010 to
8cc5c82
Compare
tobiasgiese
changed the title
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
4 times, most recently
from
b48e018 to
69bfbb9
Compare
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
2 times, most recently
from
1292634 to
50772ff
Compare
souleb
reviewed
Oct 30, 2024
souleb
reviewed
Oct 30, 2024
vasrem
reviewed
Oct 31, 2024
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
4 times, most recently
from
10bb9a2 to
c28d14f
Compare
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
from
c28d14f to
c1227ad
Compare
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
from
c1227ad to
76abbe3
Compare
|
Had to rollback the docker image changes because of dependabot/dependabot-core#2057 |
|
/retest-blackduck_scan |
rollandf
reviewed
Oct 31, 2024
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
from
76abbe3 to
25f1199
Compare
Due too multiple CVEs in the kubectl binary we remove the dependency to it. To be able to update our CRDs we introduce a custom Go binary that uses client-go to apply our CRDs and also from our dependencies, like NFD and SRIOV. Additionally we remove the scale-down Helm hook as it is no longer needed. Signed-off-by: Tobias Giese <[email protected]>
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
from
25f1199 to
bc03af3
Compare
Signed-off-by: Tobias Giese <[email protected]>
tobiasgiese
force-pushed
the
implement-new-test-scope
branch
from
bc03af3 to
29cdc84
Compare
rollandf
approved these changes
Oct 31, 2024
|
/retest-image_scan |
e0ne
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due too multiple CVEs in the kubectl binary we remove the dependency to it.
To be able to update our CRDs we introduce a custom Go binary that uses client-go
to apply our CRDs and also from our dependencies, like NFD and SRIOV.
Additionally we remove the scale-down Helm hook as it is no longer needed.
Fixes #1072