fix: Remove Helm deployment of NICClusterPolicy #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killianmuldoon
commented
Sep 27, 2024
| @@ -1,49 +0,0 @@ | |||
| {{- if and .Values.deployCR .Values.rdmaSharedDevicePlugin .deploy .Values.secondaryNetwork.deploy .Values.secondaryNetwork.multus.deploy .Values.secondaryNetwork.cniPlugins.deploy }} | |||
There was a problem hiding this comment.
Were these tests being used anywhere? They won't work after this change, but I'm wondering if this change means some loss in testing coverage.
killianmuldoon
force-pushed
the
pr-drop-helm-nicclusterpolicy-install
branch
2 times, most recently
from
fe2e617 to
89d85e0
Compare
killianmuldoon
changed the title
killianmuldoon
changed the title
killianmuldoon
force-pushed
the
pr-drop-helm-nicclusterpolicy-install
branch
from
89d85e0 to
100db60
Compare
killianmuldoon
changed the title
|
Looks like the CI is broken due to authentication 🤔 |
Pull Request Test Coverage Report for Build 11349303874Details
💛 - Coveralls |
|
/retest-all |
Signed-off-by: killianmuldoon <[email protected]>
|
/retest-all |
killianmuldoon
force-pushed
the
pr-drop-helm-nicclusterpolicy-install
branch
from
100db60 to
8fc96f2
Compare
almaslennikov
approved these changes
Oct 16, 2024
e0ne
approved these changes
Oct 16, 2024
|
Also, docs repo will need update of https://github.com/Mellanox/network-operator-docs/blob/main/templates/helm.rst.gotmpl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ability to create the NICClusterPolicy CR through helm.values. This feature has been deprecated for a number of releases and the documentation was updated to remove reference to this feature in the most recent release.
Users should instead use the helm package to install the Network Operator and configure the system by creating the NICClusterPolicy in a separate step.