-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bundle for 24.7.1 #1058
chore: bundle for 24.7.1 #1058
Conversation
Pull Request Test Coverage Report for Build 10696451539Details
💛 - Coveralls |
@rollandf let's check it using |
bundle.Dockerfile
Outdated
@@ -5,8 +5,8 @@ LABEL operators.operatorframework.io.bundle.mediatype.v1=registry+v1 | |||
LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/ | |||
LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/ | |||
LABEL operators.operatorframework.io.bundle.package.v1=nvidia-network-operator | |||
LABEL operators.operatorframework.io.bundle.channels.v1=v24.7.0-rc.1,stable | |||
LABEL operators.operatorframework.io.bundle.channel.default.v1=v24.7.0-rc.1 | |||
LABEL operators.operatorframework.io.bundle.channels.v1=v24.7.0,stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for 24.10 will we have "v24.10,stable" as channels.v1 value ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Should be handle in workflow:
https://github.com/Mellanox/network-operator/pull/1034/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR131
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should have here "v24.7.1", like we did in "v24.4.1"?
https://github.com/redhat-openshift-ecosystem/certified-operators/blob/main/operators/nvidia-network-operator/24.4.1/metadata/annotations.yaml#L8
bundle.Dockerfile
Outdated
LABEL operators.operatorframework.io.bundle.channels.v1=v24.7.0-rc.1,stable | ||
LABEL operators.operatorframework.io.bundle.channel.default.v1=v24.7.0-rc.1 | ||
LABEL operators.operatorframework.io.bundle.channels.v1=v24.7.0,stable | ||
LABEL operators.operatorframework.io.bundle.channel.default.v1=v24.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSV should be updated to to include labels including arm64 support https://github.com/NVIDIA/gpu-operator/blob/420c023825c0e7a192fd5941ebb32ed1ea76fa62/bundle/v24.6.1/manifests/gpu-operator-certified.clusterserviceversion.yaml#L5-L20
9e73f2f
to
bc7ee8b
Compare
- Add nework operator image to related images - Use multi-arch SHA Generated by: DEFAULT_CHANNEL=v24.7.0 CHANNELS=v24.7.0,stable VERSION=24.7.1 TAG=nvcr.io/nvidia/cloud-native/network-operator@sha256:b8a07696d05fb8e5292991ba731758579313d6983ed3d75dd95e7356024d987c make bundle Signed-off-by: Fred Rolland <[email protected]>
bc7ee8b
to
3592461
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's push it to certified-operators repo to check with RedHat CI before merging it
Generated by:
DEFAULT_CHANNEL=v24.7.0 CHANNELS=v24.7.0,stable VERSION=24.7.1 TAG=nvcr.io/nvidia/cloud-native/network-operator@sha256:b8a07696d05fb8e5292991ba731758579313d6983ed3d75dd95e7356024d987c make bundle