fix: add label changed predicate for node obj in upgrade controller

This change is needed because common upgrade lib is using both labels and annotations to store upgrade state. This change increase performance of the upgrade controller. Signed-off-by: Yury Kulazhenkov <[email protected]>
Mellanox · Dec 12, 2023 · c85a009 · c85a009
1 parent e68cb5a
commit c85a009
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/controllers/upgrade_controller.go b/controllers/upgrade_controller.go
@@ -222,8 +222,10 @@ func (r *UpgradeReconciler) SetupWithManager(mgr ctrl.Manager) error {
 		return ok
 	}))
 
-	// Watch for spec and annotation changes
-	nodePredicates := builder.WithPredicates(predicate.AnnotationChangedPredicate{})
+	// react only on label and annotation changes
+	nodePredicates := builder.WithPredicates(
+		predicate.Or(predicate.AnnotationChangedPredicate{},
+			predicate.LabelChangedPredicate{}))
 
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&mellanoxv1alpha1.NicClusterPolicy{}).