Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update better_errors: 2.5.1 → 2.10.0 (minor) #219

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Apr 29, 2023


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ better_errors (2.5.1 → 2.10.0) · Repo · Changelog

Security Advisories 🚨

🚨 Older releases of better_errors open to Cross-Site Request Forgery attack

Impact

better_errors prior to 2.8.0 did not implement CSRF protection for its internal requests. It also did not enforce the correct "Content-Type" header for these requests, which allowed a cross-origin "simple request" to be made without CORS protection. These together left an application with better_errors enabled open to cross-origin attacks.

As a developer tool, better_errors documentation strongly recommends addition only to the development bundle group, so this vulnerability should only affect development environments. Please ensure that your project limits better_errors to the development group (or the non-Rails equivalent).

Patches

Starting with release 2.8.x, CSRF protection is enforced. It is recommended that you upgrade to the latest release, or minimally to "~> 2.8.3".

Workarounds

There are no known workarounds to mitigate the risk of using older releases of better_errors.

References

For more information

If you have any questions or comments about this advisory, please

Release Notes

2.10.0

2.9.1

  • Fix setting editor with symbol #492

2.9.0

  • Mention path in text response #487
  • Use Github Actions for CI #489
  • Exception Hints #302
  • Hide "live shell" hint after console has been used #490
  • Improve editor support for virtual environments #488
  • Fix "live shell" hint reappearing when frame changed #491

2.8.3

  • Fix 'uninitialized constant BetterErrors::Middleware::VERSION' #480
  • Fix CSRF_TOKEN_COOKIE_NAME wrong reference to VERSION constant #481

2.8.2

  • Fix path of CSRF Token cookie #478

2.8.1

  • Show real cause of ActionView::Template::Error with Rails 6 #477
  • Add TruffleRuby to CI builds #473

2.8.0

  • Support for Rails ActionableError #465
  • Allow editor links to work inside an iframe or with CSP that prohibits other protocols #440
  • Add CSRF protection to internal requests #474
  • Validate internal request method names #475

2.7.1

  • Show location of error in ActionView template error #463

2.7.0

2.6.0

  • Specify older kramdown and i18n for older ruby versions #437
  • Fix NoMethodError when variables cannot be retrieved from the stack frame #430
  • Allow passing IPAddrs to allow_ip #444
  • Update CI Ruby to fix Travis CI failures #450

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ coderay (indirect, 1.1.2 → 1.1.3) · Repo · Changelog

Release Notes

1.1.3

Diff: v1.1.2...v1.1.3

  • Tokens: Ensure Ruby 2.6 compatibility. [#233, thanks to Jun Aruga]
  • SQL scanner: Add numeric data type. [#223, thanks to m16a1]
  • Java scanner: Add var as type. [#229, thanks to Davide Angelocola]
  • Gem: Fix deprecation warning. [#246, thanks to David Rodríguez]

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 56 commits:

↗️ erubi (indirect, 1.8.0 → 1.12.0) · Repo · Changelog

Release Notes

1.12.0 (from changelog)

* Use erb/escape for faster html escaping if available (jeremyevans)
  • Default :freeze_template_literals option to false if running with --enable-frozen-string-literal (casperisfine) (#35)

1.11.0 (from changelog)

* Support :freeze_template_literals option for configuring whether to add .freeze to template literal strings (casperisfine) (#33)
  • Support :chain_appends option for chaining appends to the buffer variable (casperisfine, jeremyevans) (#32)

  • Avoid unnecessary defined? usage on Ruby 3+ when using the :ensure option (jeremyevans)

1.10.0 (from changelog)

* Improve template parsing, mostly by reducing allocations (jeremyevans)
  • Do not ship tests in the gem, reducing gem size about 20% (jeremyevans)

  • Support :literal_prefix and :literal_postfix options for how to output literal tags (e.g. <%% code %>) (jaredcwhite) (#26, #27)

1.9.0 (from changelog)

* Change default :bufvar from 'String.new' to '::String.new' to work with BasicObject (jeremyevans)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 56 commits:

↗️ rack (indirect, 1.6.11 → 1.6.13) · Repo · Changelog

Security Advisories 🚨

🚨 Possible information leak / session hijack vulnerability

There's a possible information leak / session hijack vulnerability in Rack.

Attackers may be able to find and hijack sessions by using timing attacks
targeting the session id. Session ids are usually stored and indexed in a
database that uses some kind of scheme for speeding up lookups of that
session id. By carefully measuring the amount of time it takes to look up
a session, an attacker may be able to find a valid session id and hijack
the session.

The session id itself may be generated randomly, but the way the session is
indexed by the backing store does not use a secure comparison.

Impact:

The session id stored in a cookie is the same id that is used when querying
the backing session storage engine. Most storage mechanisms (for example a
database) use some sort of indexing in order to speed up the lookup of that
id. By carefully timing requests and session lookup failures, an attacker
may be able to perform a timing attack to determine an existing session id
and hijack that session.

Release Notes

1.6.12 (from changelog)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 22 commits:

🆕 rouge (added, 4.1.0)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Jun 15, 2023

Closed in favor of #223.

@depfu depfu bot closed this Jun 15, 2023
@depfu depfu bot deleted the depfu/update/better_errors-2.10.0 branch June 15, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants