Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story Arc Editor #4020

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from
Draft

Story Arc Editor #4020

wants to merge 48 commits into from

Conversation

AaronGullickson
Copy link
Member

No description provided.

@AaronGullickson AaronGullickson self-assigned this Apr 22, 2024
@AaronGullickson AaronGullickson added GUI Story Arcs - RFE This is specific for RFE's related to Story Arc functionality. labels Apr 22, 2024
@AaronGullickson AaronGullickson linked an issue Apr 22, 2024 that may be closed by this pull request
Create a Story Arc Editor #4019
Open
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 23, 2024
View reviewed changes
MekHQ/src/mekhq/gui/dialog/DataLoadingDialog.java
@@ -396,9 +404,13 @@
if (campaign != null) {
getApplication().setCampaign(campaign);
getApplication().getCampaignController().setHost(campaign.getId());
getApplication().showNewView();
if(storyArcEditor) {
getApplication().showNewStoryArcEditor(storyArcStub.loadStoryArc(campaign));

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
storyArcStub
Loading
may be null at this access as suggested by
this
Loading
null guard.
MekHQ/src/mekhq/gui/model/StoryOutcomeModel.java Fixed Show fixed Hide fixed
MekHQ/src/mekhq/gui/model/StoryOutcomeModel.java Fixed Show fixed Hide fixed
MekHQ/src/mekhq/gui/model/StoryOutcomeModel.java Fixed Show fixed Hide fixed
MekHQ/src/mekhq/gui/model/StoryOutcomeModel.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 24, 2024
View reviewed changes
MekHQ/src/mekhq/campaign/storyarc/storypoint/RollDiceStoryPoint.java
@@ -60,6 +63,16 @@
return Integer.toString(value);
}

public List<String> getAllPossibleResults() {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
StoryPoint.getAllPossibleResults
Loading
; it is advisable to add an Override annotation.
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 795 lines in your changes are missing coverage. Please review.

Project coverage is 10.47%. Comparing base (33a36ea) to head (8020621).
Report is 299 commits behind head on master.

❗ Current head 8020621 differs from pull request most recent head e579c30

Please upload reports for the commit e579c30 to get more accurate results.

Files Patch % Lines
...HQ/src/mekhq/gui/panels/StoryPointEditorPanel.java 0.00% 219 Missing ⚠️
MekHQ/src/mekhq/gui/StoryArcEditorGUI.java 0.00% 96 Missing ⚠️
.../mekhq/gui/dialog/CustomizeStoryOutcomeDialog.java 0.00% 91 Missing ⚠️
...s/storytriggerpanels/SetDateStoryTriggerPanel.java 0.00% 79 Missing ⚠️
MekHQ/src/mekhq/campaign/storyarc/StoryPoint.java 0.00% 33 Missing ⚠️
...rpanels/ChangeStringVariableStoryTriggerPanel.java 0.00% 25 Missing ⚠️
...riggerpanels/CompleteMissionStoryTriggerPanel.java 0.00% 24 Missing ⚠️
...ign/storyarc/storytrigger/SetDateStoryTrigger.java 0.00% 23 Missing ⚠️
...ekHQ/src/mekhq/gui/model/StoryPointTableModel.java 0.00% 22 Missing ⚠️
...storytriggerpanels/SwitchTabStoryTriggerPanel.java 0.00% 19 Missing ⚠️
... and 25 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #4020      +/-   ##
============================================
- Coverage     10.54%   10.47%   -0.08%     
+ Complexity     5605     5603       -2     
============================================
  Files           886      897      +11     
  Lines        117416   118187     +771     
  Branches      17617    17675      +58     
============================================
- Hits          12383    12380       -3     
- Misses       103774   104547     +773     
- Partials       1259     1260       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AaronGullickson AaronGullickson

Labels
GUI Story Arcs - RFE This is specific for RFE's related to Story Arc functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Story Arc Editor
2 participants
@AaronGullickson @codecov-commenter