#1527: Armor validation (see MM #6583) #1737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeds actual armor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1737 +/- ##
===========================================
- Coverage 2.14% 2.14% -0.01%
Complexity 211 211
===========================================
Files 271 273 +2
Lines 31381 31430 +49
Branches 5344 5346 +2
===========================================
Hits 674 674
- Misses 30548 30597 +49
Partials 159 159 ☔ View full report in Codecov by Sentry. |
Sleet01
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
LGTM! Noted that MML #1527 and MegaMek/megamek#6583 should be merged in close proximity to each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code adaptations for MegaMek/megamek#6583
Merge both PRs together.