Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better display of radical heat sinking in RS #1621

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

@pavelbraginskiy pavelbraginskiy commented Sep 24, 2024

Closes #1584.
Requires MegaMek/megamek#6033.

When a unit mounts optional heat sinking equipment (Coolant Pods, Radical Heat Sinks), the heat profile is unhelpful: the given Dissipation value is never actually correct, since it's an approximate average between the dissipation with the system on or off.

This PR makes the sheet display both the heat value with the system off, and with the system on.

Since official sheets do not use the Heat Profile record sheet option, this change does not affect official sheets.

Example sheets:

image
image
image

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.15%. Comparing base (f3645a6) to head (737990c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1621   +/-   ##
========================================
  Coverage      2.15%   2.15%           
  Complexity      205     205           
========================================
  Files           266     266           
  Lines         30638   30638           
  Branches       5236    5236           
========================================
  Hits            660     660           
  Misses        29825   29825           
  Partials        153     153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavelbraginskiy pavelbraginskiy added the Record Sheets Record Sheets and PDF/Printing issue label Sep 24, 2024
@rjhancock rjhancock merged commit 12e7537 into MegaMek:master Sep 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Record Sheets Record Sheets and PDF/Printing issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Display heat dissipation with radical heat sinks
3 participants