Frameless sheets #1620
Merged
Frameless sheets #1620
+151,060
−48,803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only implemented by the single-turret tank sheet. More record sheets supported soon.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
===========================================
+ Coverage 2.15% 2.17% +0.02%
- Complexity 205 209 +4
===========================================
Files 266 266
Lines 30638 30754 +116
Branches 5236 5259 +23
===========================================
+ Hits 660 669 +9
- Misses 29825 29928 +103
- Partials 153 157 +4 ☔ View full report in Codecov by Sentry. |
pavelbraginskiy
added
CGL Request
|
If this has all of the changes in #1598 as well as CGL's request, Id' suggest closing the other and making this one be all of the changes. |
rjhancock
approved these changes
Sep 28, 2024
The other one will close automatically if this one is merged, and merging the other one will update this one to only be the relevant commits. It's decently smart about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1598. Doesn't use any features from that PR per se, but it touches the same files, and this prevents merge conflicts. If that PR hasn't been merged yet, this commit is the one with all the code changes for this PR.
Adds an option to draw record sheets without frames, as requested by CGL.
Support all the 'Mechs (Bipedal, Quad, Tripod, QuadVee, LAM, and SuperHeavy variants).
Since this feature isn't expected to be useful for our non-CGL users, the ISO paper and TO heat options disable frameless output entirely, and the row shading option produces bad output.