Fix #1230: 0 Max Bay Doors on Large Fixed-Wing Sup #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix adds support for maximum door counts for Fixed-Wing Support Vehicles, as well as a count of minimum doors required for all transport bays, based on TM errata 6.0. This fix changes the Transport Tab refresh behavior: now, when the chassis type is changed in the Structure Tab, the Transport Tab will be completely re-initialized. This is so that new Fixed Wing Support Vehicles properly display the door count information (currently it only displays when loaded from a file or the chache). NOTE: depends on the same-name PR for MegaMek, which adds the 'minDoors' field for every Bay type and corrects the Max Door check in TestAero.java. Do not pull prior to that PR being pulled.
Sleet01
deleted the
fix-1230-fixed-wing-transport-does-not-meet-door-minimum
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds support for maximum door counts for Fixed-Wing Support Vehicles, as well as a count of minimum doors required for all transport bays, based on TM errata 6.0.
This fix changes the Transport Tab refresh behavior: now, when the chassis type is changed in the Structure Tab, the Transport Tab will be completely re-initialized. This is so that new Fixed Wing Support Vehicles properly display the door count information (currently it only displays when loaded from a file or the chache).
NOTE: depends on the same-name PR for MegaMek, which adds the 'minDoors' field for every Bay type and corrects the Max Door check in TestAero.java. Do not pull prior to that PR being pulled. PR is: MegaMek/megamek#4691