Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export reward list of a period - MEED-7487 - Meeds-io/MIPs#154 #611

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

AzmiTouil
Copy link
Contributor

This PR will implement the ability of export reward list of a period.

This PR will implement the ability of export reward list of a period.
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
2 New Blocker Issues (required ≤ 0)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

if (SystemUtils.IS_OS_UNIX) {
FileAttribute<Set<PosixFilePermission>> tempFileAttributes =
PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rw-------"));
return Files.createTempFile(fileName, ".xlsx", tempFileAttributes).toFile();

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarQube Cloud
PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rw-------"));
return Files.createTempFile(fileName, ".xlsx", tempFileAttributes).toFile();
} else {
File temp = Files.createTempFile(fileName, ".xlsx").toFile();

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarQube Cloud
@AzmiTouil AzmiTouil merged commit bd6e9b0 into feature/meedsv2 Nov 14, 2024
3 of 5 checks passed
@AzmiTouil AzmiTouil deleted the meed-7487 branch November 14, 2024 08:38
AzmiTouil added a commit that referenced this pull request Nov 14, 2024
…611)

This PR will implement the ability of export reward list of a period.
AzmiTouil added a commit that referenced this pull request Nov 14, 2024
…611)

This PR will implement the ability of export reward list of a period.
AzmiTouil added a commit that referenced this pull request Nov 14, 2024
…611)

This PR will implement the ability of export reward list of a period.
exo-swf pushed a commit that referenced this pull request Nov 15, 2024
…611)

This PR will implement the ability of export reward list of a period.
exo-swf pushed a commit that referenced this pull request Nov 15, 2024
…611)

This PR will implement the ability of export reward list of a period.
exo-swf pushed a commit that referenced this pull request Nov 16, 2024
…611)

This PR will implement the ability of export reward list of a period.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant