fix: Bad display after deleting a task - EXO-46811 -Meeds-io/meeds#2497. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, when creates a task in Task's project and deletes it, the deleted task drawer is still displayed. After this change, The drawer is automatically closed.
|
|
Hi Your message should answer at least 2 question ? In your message, you explain why this change is needed : "when creates a task in Task's project and deletes it, the deleted task drawer is still displayed" which is the answer to the first question, but you dont answer to the HOW. Please recheck the develop guide https://developer.exoplatform.org/#id-contributions and specially the 1.4.4 section. Then, can you reword your commit message to explain the HOW Thanks |
mkrout
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when creates a task in Task's project and deletes it, the deleted task drawer is still displayed. To resolve this problem, add the closure of this drawer after confirmation of deletion. After this change, The drawer is automatically closed.