Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show more button missing when grouping tasks by project in tasks tab EXO-72589 Meeds-io/meeds#2441 #432

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: show more button missing when grouping tasks by project in tasks tab EXO-72589 Meeds-io/meeds#2441 #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion webapps/src/main/webapp/vue-app/tasks-management/components/tasks/TasksDashboard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export default {
},
computed: {
canShowMore() {
return this.tasks.length >= this.limitToFetch && !this.filterActive;
return this.tasks.length >= this.limitToFetch;
},
showPlaceholder() {
return !this.tasks?.length && !this.loadingTasks && !this.filterActive;
Expand Down Expand Up @@ -306,6 +306,7 @@ export default {
this.labels = filterLabels.labels;
if (this.primaryFilter === 'ALL') {
this.taskQueryFilter = e;
this.taskQueryFilter.limit = this.limit;
this.resetSearch();
this.searchTasks(this.taskQueryFilter);
} else {
Expand Down Expand Up @@ -341,6 +342,10 @@ export default {
return this.$tasksService.filterTasksList(tasksFilter,this.groupBy,this.orderBy,this.labels).then(data => {
if (data.projectName){
this.filterTaskQueryResult = data;
let numberOfTasksInProjects = 0;
this.tasks = this.filterTaskQueryResult.tasks;
this.tasks.forEach(projectTasks => numberOfTasksInProjects += projectTasks.length);
this.tasks.length = numberOfTasksInProjects;
this.filterActive=true;
} else {
this.tasks = data && data.tasks || [];
Expand Down