feat: Give access to layout editor page to everyone - MEED-7657 - Meeds-io/meeds#2502 #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: - Give access to layout-editor page to anyone to let the ACL made by page permissions instead (by the Space Layout permissions if the page is added in a space) - Make the attached image to a fictive page (not really instanciated yet), accessible to all users since the page can be used in any site/space.
|
exo-swf
pushed a commit
that referenced
this pull request
Oct 25, 2024
… (#2527) Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: - Give access to layout-editor page to anyone to let the ACL made by page permissions instead (by the Space Layout permissions if the page is added in a space) - Make the attached image to a fictive page (not really instanciated yet), accessible to all users since the page can be used in any site/space.
boubaker
added a commit
that referenced
this pull request
Oct 25, 2024
… (#2527) Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: - Give access to layout-editor page to anyone to let the ACL made by page permissions instead (by the Space Layout permissions if the page is added in a space) - Make the attached image to a fictive page (not really instanciated yet), accessible to all users since the page can be used in any site/space.
boubaker
added a commit
that referenced
this pull request
Oct 25, 2024
… (#2527) Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: - Give access to layout-editor page to anyone to let the ACL made by page permissions instead (by the Space Layout permissions if the page is added in a space) - Make the attached image to a fictive page (not really instanciated yet), accessible to all users since the page can be used in any site/space.
boubaker
added a commit
that referenced
this pull request
Oct 25, 2024
… (#2527) Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: - Give access to layout-editor page to anyone to let the ACL made by page permissions instead (by the Space Layout permissions if the page is added in a space) - Make the attached image to a fictive page (not really instanciated yet), accessible to all users since the page can be used in any site/space.
boubaker
added a commit
that referenced
this pull request
Oct 29, 2024
… (#2527) Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: - Give access to layout-editor page to anyone to let the ACL made by page permissions instead (by the Space Layout permissions if the page is added in a space) - Make the attached image to a fictive page (not really instanciated yet), accessible to all users since the page can be used in any site/space.
exo-swf
pushed a commit
that referenced
this pull request
Nov 4, 2024
… (#2527) Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: - Give access to layout-editor page to anyone to let the ACL made by page permissions instead (by the Space Layout permissions if the page is added in a space) - Make the attached image to a fictive page (not really instanciated yet), accessible to all users since the page can be used in any site/space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when adding a page template, the images attached to it are not viewable by External users. This is due to the fact that the access permission of attached image is computed switch page being edited, or if of type page template to current page (layout-editor). This change will fix two bugs: