feat: Compute Kudos properties instead of relying on given parameters in HTTP call - MEED-7636 - Meeds-io/meeds#2485 #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in HTTP call - MEED-7636 - Meeds-io/meeds#2485 Prior to this change, when sending a kudos to a user or space using an id instead of remoteId, the Kudos creation succeeds while the activity generation fails. This change ensures to store in kudos attributes the right value for Kudos fields and to not rely on properties sent with kudos object as is which will ensure data consistency.
AzmiTouil
approved these changes
Oct 11, 2024
|
exo-swf
pushed a commit
that referenced
this pull request
Oct 11, 2024
… in HTTP call - MEED-7636 - Meeds-io/meeds#2485 (#543) Prior to this change, when sending a kudos to a user or space using an id instead of remoteId, the Kudos creation succeeds while the activity generation fails. This change ensures to store in kudos attributes the right value for Kudos fields and to not rely on properties sent with kudos object as is which will ensure data consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when sending a kudos to a user or space using an id instead of remoteId, the Kudos creation succeeds while the activity generation fails. This change ensures to store in kudos attributes the right value for Kudos fields and to not rely on properties sent with kudos object as is which will ensure data consistency.