Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : Initial Letters Avatars - Merge meeds-io/MIPs#83 #462

Merged
merged 2 commits into from
Feb 13, 2024
Merged

feat : Initial Letters Avatars - Merge meeds-io/MIPs#83 #462

merged 2 commits into from
Feb 13, 2024

Conversation

SaraBoutej
Copy link
Contributor

No description provided.

@SaraBoutej SaraBoutej linked an issue Feb 5, 2024 that may be closed by this pull request
Initial Letters Avatars Meeds-io/MIPs#83
Closed
@SaraBoutej
Feat: Add default user avatar when hover on reciever user name - MEED…
82b675c 
…-3111 - Meeds-io/MIPs#83 (#458)

This change adds the user enabled property in identity-popover directive for kudos message, this property allows to display the new default user avatar instead of the old one.
@SaraBoutej
feat: fix default avatar when sending kudos - MEED-3266 - Meeds-io/MI…
c00c55d 
…Ps#83 (#461)

Prior to this change, the generated default avatar is not displayed in the send kudos drawer for the receiver avatar. 
This change allows to add the user enabled property information to then receiver details to display the default avatar is the user is enabled.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

boubaker
boubaker approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@boubaker boubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated by eXo

@SaraBoutej SaraBoutej merged commit 0df2a15 into develop Feb 13, 2024
5 checks passed
@SaraBoutej SaraBoutej deleted the merge-mip-83 branch February 13, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boubaker boubaker boubaker approved these changes

@rdenarie rdenarie Awaiting requested review from rdenarie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial Letters Avatars
2 participants
@SaraBoutej @boubaker