Fix : Update Profile when synchronized profile property setting from AD - EXO-65023 - Meeds-io/meeds#1084 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
ahamdi
requested changes
Sep 6, 2023
.../java/org/exoplatform/services/organization/externalstore/IDMExternalStoreImportService.java
Show resolved
Hide resolved
| } | ||
| return internalUserProfile; | ||
| listenerService.broadcast(IDMExternalStoreService.USER_PROFILE_ADDED_FROM_EXTERNAL_STORE, this, userInfoMap); |
There was a problem hiding this comment.
IMO this should not be fired unles there is a modification
| } | ||
| return internalUserProfile; | ||
| listenerService.broadcast(IDMExternalStoreService.USER_PROFILE_ADDED_FROM_EXTERNAL_STORE, this, userInfoMap); | ||
| return null; |
There was a problem hiding this comment.
If this function does not have top return a value, we change the signature, otherwise we return the user profile as it was done
sofyenne
force-pushed
the
Task/65023
branch
3 times, most recently
from
4b77ead
to
d0082d5
Compare
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
sofyenne
force-pushed
the
Task/65023
branch
2 times, most recently
from
88e287a
to
a5916a7
Compare
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
sofyenne
force-pushed
the
Task/65023
branch
3 times, most recently
from
454c6ba
to
97dc253
Compare
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
sofyenne
force-pushed
the
Task/65023
branch
5 times, most recently
from
be8de9e
to
cb43a0b
Compare
…AD - EXO-65023 - Meeds-io/meeds#1084 update ipmortUserProfile method and add the unit test update UT
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
ahamdi
approved these changes
Sep 8, 2023
exo-swf
pushed a commit
that referenced
this pull request
Sep 11, 2023
…AD - EXO-65023 - Meeds-io/meeds#1084 (#85) Prior to this change, when we searched for synchronized people by their phone numbers, no results were displayed. This issue was due to the multi-valued synchronized property, which was saved as a map of string key-value pairs like "phones.home." This change is going to prevent the profile property from being saved using the old user profile format and will instead be saved in the format of parent and child using a map of string and object key-value pairs. It also adds the Mockito framework.
sofyenne
added a commit
that referenced
this pull request
Sep 13, 2023
…AD - EXO-65023 - Meeds-io/meeds#1084 (#85) Prior to this change, when we searched for synchronized people by their phone numbers, no results were displayed. This issue was due to the multi-valued synchronized property, which was saved as a map of string key-value pairs like "phones.home." This change is going to prevent the profile property from being saved using the old user profile format and will instead be saved in the format of parent and child using a map of string and object key-value pairs. It also adds the Mockito framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when we searched for synchronized people by their phone numbers, no results were displayed. This issue was due to the multi-valued synchronized property, which was saved as a map of string key-value pairs like "phones.home."
This change is going to prevent the profile property from being saved using the old user profile format and will instead be saved in the format of parent and child using a map of string and object key-value pairs.
It also adds the Mockito framework.