-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling Portlets Framework #144
Styling Portlets Framework #144
Comments
Hi @margondicco , to check. |
Hello ok for me For the font : I would like to add these two points in general branding :
Thank you |
Ok I added these points to be studied. |
Ready for tech review by DAO members (eXo @rdenarie ) |
Ok for me on tech side. @boubaker have you evaluate if it will have an impact on our codebase and our portlets, to apply when merging the feature ? |
Yes, there will be changes to do. But as usual, to help you receiving the feature, we will consider changes to propose on eXo side. But just keep in mind that the changes in the context of this MIP will be on some portlets only to prepare a framework, and all other portlets will be considered in #135.
|
FYI @margondicco, @rdenarie we won't make any change to newslist for now as it is currently being used by your team.
|
…theme - MEED-7094 - Meeds-io/MIPs#144 This change will rework Layout Container and application styles to rely on CSS variables in order to allow Branding a whole site with a theme that should be applied into applications easily.
…theme - MEED-7094 - Meeds-io/MIPs#144 (#793) This change will rework Layout Container and application styles to rely on CSS variables in order to allow Branding a whole site with a theme that should be applied into applications easily.
…ner - MEED-7094 - Meeds-io/MIPs#144 This change will allow to define a custom CSS class to a portlet using a portlet.xml definition inside an init param with key 'layout-css-class'.
…ner - MEED-7094 - Meeds-io/MIPs#144 (#916) This change will allow to define a custom CSS class to a portlet using a portlet.xml definition inside an init param with key 'layout-css-class'. This CSS is part of portlet definition and not attached to a particular of Portlet instance only.
…ties - MEED-7094 - Meeds-io/MIPs#144 This change will apply **application-background** class to the main body of applications to make sure to apply layout specific CSS styles, such as disabling default Vuetify White Background applied on v-card. At the same time, for Top Toolbar applications, this will disable branding styling to avoid having border radius and other styles applied on small buttons added in Top bar as applications.
…ties - MEED-7094 - Meeds-io/MIPs#144 (#3916) This change will apply **application-background** class to the main body of applications to make sure to apply layout specific CSS styles, such as disabling default Vuetify White Background applied on v-card. At the same time, for Top Toolbar applications, this will disable branding styling to avoid having border radius and other styles applied on small buttons added in Top bar as applications.
…ties - MEED-7094 - Meeds-io/MIPs#144 This change will apply **application-background** class to the main body of applications to make sure to apply layout specific CSS styles, such as disabling default Vuetify White Background applied on v-card. At the same time, for Top Toolbar applications, this will disable branding styling to avoid having border radius and other styles applied on small buttons added in Top bar as applications.
…ties - MEED-7094 - Meeds-io/MIPs#144 (#132) This change will apply **application-body** class to the main body of applications to make sure to apply layout specific CSS styles, such as disabling default Vuetify White Background applied on v-card. At the same time, for Top Toolbar applications, this will disable branding styling to avoid having border radius and other styles applied on small buttons added in Top bar as applications.
…ties - MEED-7094 - Meeds-io/MIPs#144 This change will apply **application-body** class to the main body of applications to make sure to apply layout specific CSS styles, such as disabling default Vuetify White Background applied on v-card. At the same time, for Top Toolbar applications, this will disable branding styling to avoid having border radius and other styles applied on small buttons added in Top bar as applications.
…ties - MEED-7094 - Meeds-io/MIPs#144 (#132) This change will apply **application-body** class to the main body of applications to make sure to apply layout specific CSS styles, such as disabling default Vuetify White Background applied on v-card. At the same time, for Top Toolbar applications, this will disable branding styling to avoid having border radius and other styles applied on small buttons added in Top bar as applications.
…io/MIPs#144 (#135) This change allow to define text color per application for header, simple and subtitle texts.
…/MIPs#144 (#137) This change will allow to brand application body contents independently from General Branding/Theme color using different CSS variables.
Prior to this change, after increasing the font-size in Meeds-io/MIPs#144, the predefined line-height of List, in dense configuration, isn't adapted and truncates the bottom of some latin characters. This change ensures to use element relative unit ('em' instead of 'rem') to make this more flexible and adds a small spacing in case of big used fonts.
…833) Prior to this change, after increasing the font-size in Meeds-io/MIPs#144, the predefined line-height of List, in dense configuration, isn't adapted and truncates the bottom of some latin characters. This change ensures to use element relative unit ('em' instead of 'rem') to make this more flexible and adds a small spacing in case of big used fonts.
…833) Prior to this change, after increasing the font-size in Meeds-io/MIPs#144, the predefined line-height of List, in dense configuration, isn't adapted and truncates the bottom of some latin characters. This change ensures to use element relative unit ('em' instead of 'rem') to make this more flexible and adds a small spacing in case of big used fonts.
…833) Prior to this change, after increasing the font-size in Meeds-io/MIPs#144, the predefined line-height of List, in dense configuration, isn't adapted and truncates the bottom of some latin characters. This change ensures to use element relative unit ('em' instead of 'rem') to make this more flexible and adds a small spacing in case of big used fonts.
…833) Prior to this change, after increasing the font-size in Meeds-io/MIPs#144, the predefined line-height of List, in dense configuration, isn't adapted and truncates the bottom of some latin characters. This change ensures to use element relative unit ('em' instead of 'rem') to make this more flexible and adds a small spacing in case of big used fonts.
…835) Prior to this change, after increasing the font-size in Meeds-io/MIPs#144, the predefined line-height of List, in dense configuration, isn't adapted and truncates the bottom of some latin characters. This change ensures to use element relative unit ('em' instead of 'rem') to make this more flexible and adds a small spacing in case of big used fonts.
…835) Prior to this change, after increasing the font-size in Meeds-io/MIPs#144, the predefined line-height of List, in dense configuration, isn't adapted and truncates the bottom of some latin characters. This change ensures to use element relative unit ('em' instead of 'rem') to make this more flexible and adds a small spacing in case of big used fonts.
Rationale
The Meeds Layout Manager enables different options to customize pages and portlets:
Considering it, we identified we needed to work on a global review of portlets (cf. MIP #135 )
Before working on such a cleanup, we suggest to implement a framework so we can variabilize such items to then apply it to each portlet. This will help other team to do the cleanup.
1. Functional Requirements
Top User Stories
Precision: only content portlets (snv, link, image) and portlets provided in the dashboard page (AKA overview) will be tested during this implementation to test it out
This framework must help us to manage:
As all these items will be variabilized in a global framework, we suggest to provide new options to set default styling.
Hence, from the branding options (theme page), we would be able to:
All pages are reviewed in order to apply these styling characteristics.
As for instance:
And some specific style is applied for few items:
Everything is detailed there: https://builders.meeds.io/portal/g/:spaces:developers/developers/notes/526
Impacts
Gamification
NA
Notifications
NA
Analytics
NA
Unified Search
NA
2. Technical Requirements
Expected Volume & Performance
N/A
Security
The Branding Options has to remain modifiable by Administrators only.
The read/write of user's theme (dark/light) has to be accessible to current user only.
Extensibility
N/A
Configurability
The default branding options has to remain configurable through branding.less file.
Upgradability
No data upgrade should be necessary in order to benifit from this feature.
Existing Features
No change to apply on default branding primary, secondary and tertiary colors for now, which may not fit the dark mode.
Feature Flags
N/A
Other Non Functional Requirements
N/A
3. Software Architecture
Security
Access
application-body
. This class will define all customizable CSS branding properties, such as colors, heights, margins ...Services & processing
branding.less
has to be defined by theme to allow defining default colors in both modes: light and dark.:root
element, a new path parameter has to be added in order to specify which theme is usedBrandingService
has to be updated consequently in order to allow processing both themes at startup time.Data and persistence
Local Storage
only in order to allow choosing the preferred theme by Device and by Browser.The text was updated successfully, but these errors were encountered: