Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to add all loggable types to metadata #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Schroedes
Copy link

We wanted the ability to add more types to the metadata besides just string. Rather than just adding support for the Pose, we added support for all LoggableTypes, the only method not replicated over is Mechanism2D since there wouldn't be much point to save this in metadata.
ex. Camera Pose Constants

@jwbonner
Copy link
Member

Could you elaborate a bit on your use case? In general, the purpose of metadata is to record information available only at runtime (i.e. HAL runtime type) or build time (i.e. Git SHA). I'm a bit confused about the use case here, given that camera poses would presumably be part of the source code that's versioned controlled anyway to enable replay. For visualizing poses in AdvantageScope, I imagine it's generally more helpful to log them as separate fields so they can be visualized alongside other data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants